fix(logs): right-size and reorganize log-detail action chips#5352
Conversation
Two concrete regressions from the earlier Chip conversion (#5341): - Both chips used variant='primary' (the solid inverse-fill treatment), the heaviest chrome in the design system, reserved for a single standout action per context (Save, Upgrade, Add key) — never a peer among several row actions. Two solid pills stacked in a narrow side panel read as oversized. Switched both to the bare (default) chip, matching every analogous row action in Settings. - The Version badge was size='md' while its siblings (Level, Trigger) are size='sm' — an inconsistency. Aligned to 'sm'. Also folded the floating 'Troubleshoot in Chat' chip into the Details card as its own row (matching 'Snapshot' exactly) instead of leaving it orphaned below Workflow Output — every row in the card now shares one shape (label left, trailing content right), consistent top to bottom.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The Version badge is Troubleshoot in Chat moves from a standalone chip below Workflow Output into the Details card as a labeled row (label left, chip right), same pattern as Snapshot. Troubleshoot behavior is unchanged. Reviewed by Cursor Bugbot for commit 7ab2fee. Configure here. |
Greptile SummaryThis PR is a focused UI polish pass on the Log Details panel: it normalizes the Version badge from
Confidence Score: 5/5This is a pure layout and styling change — no business logic, state, or data-fetching is touched. All three modifications are isolated to JSX props and element positioning within one component. The existing Eye and Wrench icon imports were already present, the Troubleshoot onClick handler is unchanged, and conditional guards (showWorkflowState, canTroubleshoot) are unaffected. The only runtime difference is visual. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Details Card] --> B[Level row]
A --> C[Trigger row]
A --> D[Duration row]
A --> E[Version row\nbadge size='sm']
A --> F{showWorkflowState?}
F -->|yes| G[Snapshot row\nChip default variant]
A --> H{canTroubleshoot?}
H -->|yes| I[Troubleshoot row\nChip default variant\n moved here from below Workflow Output]
style G fill:#d4edda,stroke:#28a745
style I fill:#d4edda,stroke:#28a745
style E fill:#d4edda,stroke:#28a745
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[Details Card] --> B[Level row]
A --> C[Trigger row]
A --> D[Duration row]
A --> E[Version row\nbadge size='sm']
A --> F{showWorkflowState?}
F -->|yes| G[Snapshot row\nChip default variant]
A --> H{canTroubleshoot?}
H -->|yes| I[Troubleshoot row\nChip default variant\n moved here from below Workflow Output]
style G fill:#d4edda,stroke:#28a745
style I fill:#d4edda,stroke:#28a745
style E fill:#d4edda,stroke:#28a745
Reviews (1): Last reviewed commit: "fix(logs): right-size and reorganize log..." | Re-trigger Greptile |
Summary
variant='primary'(the solid inverse-fill chip), which is reserved platform-wide for a single standout action per context (Save, Upgrade, Add key), never a peer among several row actions. Two solid pills stacked in a narrow side panel read as oversized against Settings' equivalent rows, which stay bare.size='md'while its siblings (Level, Trigger) aresize='sm'— an inconsistency.Type of Change
Testing
type-check,biome,check:client-boundary,check:api-validationall pass on an isolated branch (no unrelated changes).Checklist